MCP: Relax redirectUri validation to allow any URI scheme #667
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows native apps such as Cursor to redirect to cursor://xyz and use oauth DCR. Https is enforced on non-localhost URIs
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursor is not able to use oauth DCR to connect to the MCP server because they want to redirect to
cursor://anysphere.cursor-mcp/oauth/callback, which is currently not allowed and results in the following error:Redirect URIs must be localhost or HTTPS. This PR relaxes redirectUri validation to allow for any URI scheme, except for http to external URIs.Seems like cursor is a bit ahead of the spec here, though the python SDK has also gone this path: modelcontextprotocol/python-sdk#895
Closes #652