Conversation
This was referenced Feb 3, 2026
Merged
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 3, 2026
camielvs
force-pushed
the
01-30-feat_add_basic_flexnode
branch
from
2af69e9 to
f1ed428
Compare
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
2 times, most recently
from
2d288bb to
a6cbf9a
Compare
camielvs
force-pushed
the
01-30-feat_add_basic_flexnode
branch
from
f1ed428 to
7c35804
Compare
camielvs
changed the base branch from
01-30-feat_add_basic_flexnode
to
graphite-base/1746
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
a6cbf9a to
bc9de49
Compare
camielvs
changed the base branch from
graphite-base/1746
to
01-30-feat_add_sticky_notes_to_canvas
camielvs
changed the base branch from
01-30-feat_add_sticky_notes_to_canvas
to
graphite-base/1746
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
bc9de49 to
bcd8b6e
Compare
camielvs
force-pushed
the
graphite-base/1746
branch
from
15e5a3a to
882b3f0
Compare
camielvs
changed the base branch from
graphite-base/1746
to
02-03-temp_flex_node_architecture
camielvs
force-pushed
the
02-03-temp_flex_node_architecture
branch
from
882b3f0 to
bb2dbfc
Compare
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
bcd8b6e to
4223c4a
Compare
camielvs
changed the base branch from
02-03-temp_flex_node_architecture
to
graphite-base/1746
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
4223c4a to
b336e1a
Compare
camielvs
changed the base branch from
graphite-base/1746
to
01-30-feat_add_sticky_notes_to_canvas
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
2 times, most recently
from
f9ef198 to
4d515c7
Compare
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
045fa7a to
a70364d
Compare
camielvs
force-pushed
the
01-30-feat_add_sticky_notes_to_canvas
branch
from
a21c78b to
0ac16eb
Compare
This was referenced Feb 10, 2026
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
a70364d to
020ba6c
Compare
camielvs
force-pushed
the
01-30-feat_add_sticky_notes_to_canvas
branch
from
0ac16eb to
8d24c73
Compare
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
2 times, most recently
from
a6739fb to
e19c055
Compare
camielvs
force-pushed
the
01-30-feat_add_sticky_notes_to_canvas
branch
from
8d24c73 to
76cc651
Compare
camielvs
requested review from
a team,
Mbeaulne and
maxy-shpfy
and removed request for
a team
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
e19c055 to
629e8e6
Compare
camielvs
force-pushed
the
01-30-feat_add_sticky_notes_to_canvas
branch
from
76cc651 to
1800cff
Compare
camielvs
force-pushed
the
02-03-feat_delete_flex_nodes
branch
from
629e8e6 to
e94cb92
Compare
maxy-shpfy
reviewed
Feb 19, 2026
src/components/shared/ReactFlow/FlowCanvas/ConfirmationDialogs/DeleteConfirmation.tsx
Show resolved
Hide resolved
maxy-shpfy
reviewed
Feb 19, 2026
maxy-shpfy
reviewed
Feb 19, 2026
| return str; | ||
| } | ||
|
|
||
| if (!options.breakWords) { |
Collaborator
There was a problem hiding this comment.
I'm 50/50. I see across the app we have kinda a mess around "truncating". This specific method is always used with {breakWords: false} which contradicts with defaults.
My suggestion is to remove "options" and keep this as a method "truncateWithoutBreakingWords" or smth.
Collaborator
Author
There was a problem hiding this comment.
We do have a bit of a mess. I originally made a specific truncateWithoutBreakingWords style method but then realised maybe instead of adding to the mess I could make a generic wider-purpose truncate instead. Hence why I included options even though nothing is really consuming it at the moment. My hope is that we can migrate old code to it & use it in future for a more consistent system - like pluralize
maxy-shpfy
reviewed
Feb 19, 2026
maxy-shpfy
reviewed
Feb 19, 2026
src/components/shared/ReactFlow/FlowCanvas/ConfirmationDialogs/DeleteConfirmation.tsx
Outdated
Show resolved
Hide resolved
maxy-shpfy
approved these changes
Feb 19, 2026
Collaborator
Author
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Can now delete a sticky note from the canvas using the DELETE key.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/118
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments