Skip to content

fix: Edges use zIndex from Connected Nodes#1761

Open
camielvs wants to merge 1 commit into02-05-feat_zindex_management_for_io_nodesfrom
02-05-fix_edges_use_zindex_from_connected_nodes
Open

fix: Edges use zIndex from Connected Nodes#1761
camielvs wants to merge 1 commit into02-05-feat_zindex_management_for_io_nodesfrom
02-05-fix_edges_use_zindex_from_connected_nodes

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Feb 5, 2026

Description

Edges will automatically use the maximum zIndex of the two connected nodes.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/483

Type of Change

  • Bug fix

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before:

edge-bring-to-front-notfixed.mov (uploaded via Graphite)

After:

edge-bring-to-front-fixed.mov (uploaded via Graphite)

Test Instructions

  • Put three tasks on the canvas. Link two of them together.
  • The unlinked task "Bring to Front" and drag it over the other two.
  • On one of the two linked tasks now "Bring to Front" one of them.
  • You should see the task come to front, as well as the edges connected to it.

Additional Comments

Copy link
Collaborator Author

camielvs commented Feb 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from 67775fc to e673511 Compare February 5, 2026 22:36
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch from c61f27b to 2db9e39 Compare February 5, 2026 22:36
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from e673511 to 90fab04 Compare February 6, 2026 16:07
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch from 2db9e39 to 553d1eb Compare February 6, 2026 16:07
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from 90fab04 to f4f140b Compare February 6, 2026 19:40
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch 3 times, most recently from f759585 to bb361f6 Compare February 6, 2026 19:49
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from 13a4131 to e87f47d Compare February 6, 2026 21:47
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch 2 times, most recently from 44a6e9a to d0f2029 Compare February 6, 2026 22:19
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from e87f47d to b2ab23d Compare February 6, 2026 22:19
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch from d0f2029 to 3960bb7 Compare February 6, 2026 22:47
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from b2ab23d to 8960935 Compare February 6, 2026 22:47
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch from 3960bb7 to 3cf77a7 Compare February 6, 2026 23:02
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch 2 times, most recently from 6f3ae39 to aaa8df1 Compare February 6, 2026 23:09
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch from 3cf77a7 to d9d84f4 Compare February 6, 2026 23:09
@camielvs camielvs force-pushed the 02-05-feat_zindex_management_for_io_nodes branch from aaa8df1 to dce220c Compare February 6, 2026 23:17
@camielvs camielvs force-pushed the 02-05-fix_edges_use_zindex_from_connected_nodes branch from d9d84f4 to 5d47149 Compare February 6, 2026 23:17
@camielvs camielvs marked this pull request as ready for review February 6, 2026 23:34
@camielvs camielvs requested a review from a team as a code owner February 6, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant