Use TypeError for non-string input in count_vowels#14193
Closed
yaadhuu wants to merge 4 commits intoTheAlgorithms:masterfrom
Closed
Use TypeError for non-string input in count_vowels#14193yaadhuu wants to merge 4 commits intoTheAlgorithms:masterfrom
yaadhuu wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the exception type raised in
count_vowelswhen the inputis not a string.
Currently, the function raises
ValueErrorfor invalid input types. Since this caserepresents an incorrect input type rather than an invalid value, this PR replaces
it with
TypeError, which aligns better with Python’s exception conventions.What changed
ValueErrorwithTypeErrorfor non-string inputs incount_vowelsWhy this change
Using
TypeErrorfor incorrect input types makes the function’s behavior clearer andmore consistent with standard Python practices, improving readability and correctness
for users.
Checklist