Open
Conversation
Author
|
Any chance this can be merged soon? Maybe together with upgrade to 5.4.0 #221? |
Owner
|
Hi! Thank you for the PR. Unfortunately I've not yet had the time to investigate this and I don't want to commit to a particular “easy” solution that might not be the best solution within the context of this Docker image. |
|
Wouldn't it be simpler to handle it like this? if [ -n "$ADMINER_DESIGN" ]; then
# Only create link on initial start, to ensure that explicit changes to
# adminer.css after the container was started once are preserved.
if [ ! -e .adminer-init ]; then
- ln -sf "designs/$ADMINER_DESIGN/adminer.css" .
+ for css_file in adminer.css adminer-dark.css; do
+ if [ -f "designs/$ADMINER_DESIGN/$css_file" ]; then
+ ln -sf "designs/$ADMINER_DESIGN/$css_file" adminer.css
+ break
+ fi
+ done
fi
fiThis avoids introducing an extra variable. |
Author
|
I am not sure persisting changes to a theme is desired as a default? If personal changes are needed it could maybe be solved with mounting your own css? The extra variable is required to give the user a choice between light and dark mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new environment variable to support new dark mode functionality.
Fixes #198
Fixes #218
Updated docs PR docker-library/docs#2577