Upgrade diff dependency from v4 to v8.0.3 (GHSA-73rr-hh4g-fpgx) #2169
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security fix: Upgrades the `diff` package from v4.0.1 to v8.0.3 to address security vulnerability GHSA-73rr-hh4g-fpgx (DoS in parsePatch/applyPatch). Changes: - Updated diff from ^4.0.1 to ^8.0.3 - Removed @types/diff (v8 includes built-in TypeScript types) Note: ts-node only uses diffLines() which is NOT affected by this vulnerability, but upgrading resolves npm audit warnings.
nsalto
approved these changes
Jan 16, 2026
|
Thank you for putting this together! Would be great to get this out. I noticed the MR was pointing towards main, which lists is version as 11.0.0-beta.1. I see there is still a 10.x branch though which lists version 10.9.2. Question for the maintainers - could this patch be backported to v10.x considering v11 never left beta? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the
diffpackage from v4 to v8.0.3 to address security vulnerability GHSA-73rr-hh4g-fpgx.Security Advisory
parsePatch()andapplyPatch()- line break characters can cause infinite loops or ReDoSdiffLines()which is NOT affected by this vulnerabilityChanges
difffrom^4.0.1to^8.0.3@types/diff(v8 includes built-in TypeScript types)Impact
diffLines()is used insrc/repl.tsfor REPL code execution