Updates to star collector from play testing feedback#59
Open
Updates to star collector from play testing feedback#59
Conversation
thompson318
reviewed
Mar 4, 2026
Member
thompson318
left a comment
There was a problem hiding this comment.
This works for me and has no conflicts with main now. I do get bad behaviour if I set start sampling to be anything greater than ~12. I think it's worth digging a bit deeper in the cause of that before merging.
| [SerializeField, Tooltip("Distance between generated stars on the y axis")] | ||
| private float starCreationDistance = 2.5f; | ||
| [SerializeField, Tooltip("Number of stars to spawn per cycle of the wave")] | ||
| private float starSampling = 8f; |
Member
There was a problem hiding this comment.
There seems to be a maximum value for this before the level crashes. 12 worked for me but 14 gives the following error.
Which is
Perhaps there is a failure in creating the game manager when star sampling is too high. Would be worth looking into in case it's a more general bug. Other wise we could just constrain the allowable values of star sampling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #55
Changes:
Made the time limit increment configurable via the unity editor (was previously fixed at 30 seconds)
Added the concept of 'win streaks' to match the implementation of the other games. Now you can set a certain number of games in a row that must meet the upgrade criteria in order to increase the time limit.
I changed the
starCreationDistanceparameter (the y distance between stars) to astarSamplingparameter (number of stars to spawn per cycle of the wave). This made it easier to try different levels ofswerve(i.e. different wave frequencies) while still getting adequate sampling to see the wave shape.Increased the base star speed, but mostly increased the wave's 'swerve' (i.e. made it oscillate more frequently left to right). Speed increases alone made the stars very hard to follow visually, so a balance of speed + tighter wave oscillation seemed to work best.
I've sent updated game builds to David, so hopefully he can give input on the star speed / wave shape. It may be easier to try out different parameters with him live on a call, so you can quickly cycle through options and see what fits best.