Skip to content

feat(AnalyticalTable): add allVisibleRowsSelected to onRowSelect & improve select behavior #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lukas742 wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(AnalyticalTable): add allVisibleRowsSelected to onRowSelect & improve select behavior #8224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e3b471e
feat(AnalyticalTable): refactor onRowSelect to use instance-based pen…
Lukas742 Feb 9, 2026
3d43b76
Update AnalyticalTable.cy.tsx
Lukas742 Feb 12, 2026
612e87b
fork react-table `useRowSelect` and adjust it
Lukas742 Feb 12, 2026
8c23fb8
fix select-all indeterminate
Lukas742 Feb 12, 2026
6bfac8b
remove redundant defaults
Lukas742 Feb 12, 2026
e2481c7
useRowSelect: comments & cleanup
Lukas742 Feb 16, 2026
08a2abb
Make `isSelectionEnabled` available on table instance
Lukas742 Feb 16, 2026
30b7b42
add missing instance types
Lukas742 Feb 16, 2026
92956ff
keep selection when `loading` or overlay is active
Lukas742 Feb 16, 2026
c52ec8f
add tests
Lukas742 Feb 16, 2026
d466a8c
no-data: hide select-all cb
Lukas742 Feb 16, 2026
a08bccd
add test for hidden cb
Lukas742 Feb 16, 2026
3c8b4c6
fix event type
Lukas742 Feb 16, 2026
2fa937e
Update useSelectionChangeCallback.ts
Lukas742 Feb 16, 2026
3465644
Update useRowSelect.ts
Lukas742 Feb 16, 2026
5623342
fix parent row selection in `useIndeterminateRowSelection` & improve …
Lukas742 Feb 17, 2026
0fdb0e9
Merge branch 'main' into feat/at-row-select
Lukas742 Feb 17, 2026
ef00e9e
fix unecessary memoization & subRows early exit, small performance im…
Lukas742 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions REUSE.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,9 @@ path = "packages/main/src/internal/safeGetChildrenArray.ts"
precedence = "aggregate"
SPDX-FileCopyrightText = "2022 Adobe Inc."
SPDX-License-Identifier = "Apache-2.0"

[[annotations]]
path = "packages/main/src/components/AnalyticalTable/hooks/useRowSelect.ts"
precedence = "aggregate"
SPDX-FileCopyrightText = "2019-2021 Tanner Linsley"
SPDX-License-Identifier = "MIT"
253 changes: 229 additions & 24 deletions packages/main/src/components/AnalyticalTable/AnalyticalTable.cy.tsx
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 14 additions & 8 deletions packages/main/src/components/AnalyticalTable/AnalyticalTable.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,20 @@
user-select: none;
}

.checkBox::part(root) {
display: flex;
width: unset;
height: unset;
justify-content: center;
min-height: unset;
min-width: unset;
padding: 0;
.checkBox {
vertical-align: middle;
pointer-events: none;
display: block;

&::part(root) {
display: flex;
width: unset;
height: unset;
justify-content: center;
min-height: unset;
min-width: unset;
padding: 0;
}
}

/* ==========================================================================
Expand Down
24 changes: 23 additions & 1 deletion packages/main/src/components/AnalyticalTable/AnalyticalTable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,29 @@ const meta = {
chromatic: { disableSnapshot: true },
},
args: {
data: dataLarge,
// reactTableOptions: { autoResetSelectedRows: true },
data: [
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
...dataLarge,
],
columns: [
{
Header: 'Name',
Expand Down
Loading
Loading