fix(ui5-side-navigation): update visual styles#13047
Open
LidiyaGeorgieva wants to merge 13 commits intomainfrom
Open
fix(ui5-side-navigation): update visual styles#13047LidiyaGeorgieva wants to merge 13 commits intomainfrom
LidiyaGeorgieva wants to merge 13 commits intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13047--ui5-webcomponents-preview.netlify.app |
Stoev
reviewed
Feb 12, 2026
dimovpetar
requested changes
Feb 16, 2026
s-todorova
requested changes
Feb 17, 2026
| // Click on a SideNavigationItem | ||
| cy.get("[ui5-side-navigation-item]").first().realClick(); | ||
|
|
||
| // SideNavigation should remain expanded because mode is not Auto |
Contributor
There was a problem hiding this comment.
Contradiction between comment and assertion: - comment states "should remain expanded" vs ""collapsed", true" assertion
| } | ||
|
|
||
| private _attachSideNavigationListeners() { | ||
| const sideNavigation = this.sideContent[0]; |
Contributor
There was a problem hiding this comment.
If we put something else in the sideContent slot other than SideNavigation, the event listener below will break. Maybe we can also do a isInstanceOfSideNavigation(sideNavigation) check just to be safe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After feedback from the designers, we fixed some issues and made some improvements.
JIRA: 3598