Library: fix race conditions in device management#687
Open
reinauer wants to merge 1 commit intoUSBGuard:mainfrom
Open
Library: fix race conditions in device management#687reinauer wants to merge 1 commit intoUSBGuard:mainfrom
reinauer wants to merge 1 commit intoUSBGuard:mainfrom
Conversation
The _sysfs_path_to_id_map and _backlog structures were being accessed concurrently by the main thread and the uevent thread without proper synchronization. This could lead to memory corruption or erroneous device rejections during the initial system scanning phase. Fix this by: 1. Protecting _sysfs_path_to_id_map in DeviceManagerBase using the existing refDeviceMapMutex(). 2. Protecting the event _backlog in UEventDeviceManager using a dedicated static mutex to ensure thread-safe buffering and handoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _sysfs_path_to_id_map and _backlog structures were being accessed
concurrently by the main thread and the uevent thread without proper
synchronization. This could lead to memory corruption or erroneous
device rejections during the initial system scanning phase.
Fix this by:
existing refDeviceMapMutex().
dedicated static mutex to ensure thread-safe buffering and handoff.