chore: add 5 production bug reports to TODO (GH#902-906)#908
Merged
superdav42 merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughTODO.md was updated to fix a missing newline at the end of the file and append a new "Production Bugs (2026-04-22)" section containing five new task entries documenting identified production issues. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@TODO.md`:
- Around line 126-130: The TODO entries (t529, t528, t530, t526, t527) lack
explicit acceptance criteria and concrete file targets; update each task line in
TODO.md to include: a short, testable acceptance criterion (what to observe
after the fix, e.g., "watchdog cancellation removes pending_site meta and no
orphan remains"), the primary files or functions to change (e.g., membership
watchdog handler, WC order completion handler, checkout flow wp_insert_user
call, checkout.min.js validator, password strength default), and a verification
checklist (manual steps or unit/integration tests to run). For each task use the
existing task id (t529, t528, t530, t526, t527), append a one-sentence
acceptance test, list the exact file(s)/symbols to modify (e.g.,
MembershipWatchdog::cancelMembership, wc_order_complete_handler,
checkout.wp_insert_user call site, checkout.min.js validator strings,
password_strength config/default), and a short "how to verify" step so the task
is worker-ready.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+126
to
+130
| - [ ] t529 fix(membership): orphan pending_site after membership cancellation — watchdog cancels membership but pending_site meta stays, customer retries checkout and gets no site #bug #auto-dispatch ~4h ref:GH#902 | ||
| - [ ] t528 fix(checkout): duplicate WP users created on checkout retry — wp_insert_user called without get_user_by email check #bug #auto-dispatch ~2h ref:GH#903 | ||
| - [ ] t530 fix(checkout): reclaim orphan pending_site on WC order completion — no code picks up transferable pending_site when payment succeeds #bug #auto-dispatch ~4h ref:GH#904 | ||
| - [ ] t526 fix(i18n): JS checkout validator missing i18n strings — field_required etc. hardcoded English in checkout.min.js #bug #auto-dispatch ~2h ref:GH#905 | ||
| - [ ] t527 fix(ux): default minimum_password_strength too strict — super_strong rejects reasonable passwords, default to strong #enhancement #auto-dispatch ~1h ref:GH#906 No newline at end of file |
Contributor
There was a problem hiding this comment.
Please add explicit acceptance criteria + concrete file targets for each new bug task.
These entries are useful, but they don’t currently include clear acceptance criteria (and most don’t name target files), which conflicts with the stated “worker-ready” objective and can lead to inconsistent fixes.
Suggested TODO format upgrade
- - [ ] t529 fix(membership): orphan pending_site after membership cancellation — watchdog cancels membership but pending_site meta stays, customer retries checkout and gets no site `#bug` `#auto-dispatch` ~4h ref:GH#902
+ - [ ] t529 fix(membership): orphan pending_site after membership cancellation `#bug` `#auto-dispatch` ~4h ref:GH#902
+ - Files: inc/functions/membership.php, inc/managers/class-site-manager.php
+ - Acceptance criteria:
+ - On cancellation, `pending_site` meta is removed or marked reclaimable.
+ - Retried checkout provisions site successfully (no blocked retry path).
+ - Regression test covers cancellation → retry flow.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@TODO.md` around lines 126 - 130, The TODO entries (t529, t528, t530, t526,
t527) lack explicit acceptance criteria and concrete file targets; update each
task line in TODO.md to include: a short, testable acceptance criterion (what to
observe after the fix, e.g., "watchdog cancellation removes pending_site meta
and no orphan remains"), the primary files or functions to change (e.g.,
membership watchdog handler, WC order completion handler, checkout flow
wp_insert_user call, checkout.min.js validator, password strength default), and
a verification checklist (manual steps or unit/integration tests to run). For
each task use the existing task id (t529, t528, t530, t526, t527), append a
one-sentence acceptance test, list the exact file(s)/symbols to modify (e.g.,
MembershipWatchdog::cancelMembership, wc_order_complete_handler,
checkout.wp_insert_user call site, checkout.min.js validator strings,
password_strength config/default), and a short "how to verify" step so the task
is worker-ready.
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
|
Performance Test Results Performance test results for 94cdc10 are in 🛎️! Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown. URL:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds TODO entries for 5 production bugs discovered on 2026-04-22, with linked GitHub issues:
pending_siteafter membership cancellation — watchdog cancels but pending_site meta stays, blocking site provisioning on retrywp_userson checkout retry —wp_insert_user()called withoutget_user_by('email')checkpending_siteon WC order completion — customer pays, gets nothingfield_requiredetc.minimum_password_strengthtoo strict (super_strong/ zxcvbn 4)All 5 issues have worker-ready bodies with file references and acceptance criteria. Tagged
#auto-dispatchfor autonomous implementation.Ref #902, Ref #903, Ref #904, Ref #905, Ref #906
aidevops.sh v3.8.94 plugin for OpenCode v1.3.17 with claude-opus-4-6 spent 4m and 7,404 tokens on this as a headless worker.
Summary by CodeRabbit