[pull] master from monkeytypegame:master #791
Merged
+283
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description This PR adds support for the **Kinyarwanda** language. * Created `kinyarwanda.json` with a word list of 200+ unique, lowercase words. * Registered `"kinyarwanda"` in the shared `LanguageSchema` within `packages/schemas` to ensure type safety across the monorepo. * Added `"kinyarwanda"` to the `LanguageGroups` in the frontend constants so it appears correctly in the user settings menu under the appropriate category. ### Checks * [x] Adding/modifying Typescript code? * [x] I have used `qs`, `qsa` or `qsr` instead of JQuery selectors. * [ ] Adding quotes? * [x] Adding a language? * Make sure to follow the [[languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md)](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) * [x] Add language to `packages/schemas/src/languages.ts` * [x] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` * [x] Add language json file to `frontend/static/languages` * [ ] Adding a theme? * [ ] Adding a layout? * [ ] Adding a font? * [x] Check if any open issues are related to this PR; if so, be sure to tag them below. * [x] Make sure the PR title follows the Conventional Commits standard. * [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )