Skip to content

Fix crash from joining the event thread on itself #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xusheng6 merged 2 commits into from
Apr 8, 2026
+11 −1
Merged

Fix crash from joining the event thread on itself #1047

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc76983
Fix crash from joining the event thread on itself
xusheng6 Apr 6, 2026
d490308
Use detached std::thread instead of WorkerEnqueue for accessor deletion
xusheng6 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion core/debuggercontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,8 +1875,18 @@ void DebuggerController::EventHandler(const DebuggerEvent& event)

if (m_accessor)
{
delete m_accessor;
// Defer deletion to a detached thread. The accessor holds a DbgRef<DebuggerController>,
// and if it is the last reference, deleting it here (on the event thread) would trigger
// ~DebuggerController which calls m_debuggerEventThread.join() -- deadlocking/crashing
// because we ARE the event thread.
//
// This can happen when Destroy() races with event processing: EventHandler sets
// ConnectionStatus to NotConnected (line above), and another thread observes this,
// calls Destroy() which removes the global array ref, making the accessor's DbgRef
// the last reference to the controller.
auto* accessor = m_accessor;
m_accessor = nullptr;
std::thread([accessor]() { delete accessor; }).detach();
}
m_lastIP = m_currentIP;
m_currentIP = 0;
Expand Down