Skip to content

Fix use-after-free crash in UI callbacks on rebase #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xusheng6 merged 1 commit into from
Apr 8, 2026
+11 −2
Merged

Fix use-after-free crash in UI callbacks on rebase #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion api/debuggercontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,10 @@ void DebuggerController::RemoveEventCallback(size_t index)

void DebuggerController::SetDebuggerUICallbacks(DebuggerUICallbacks* cb)
{
BNDebuggerSetDebuggerUICallbacks(m_object, cb->GetCallbacks(), cb);
if (cb)
BNDebuggerSetDebuggerUICallbacks(m_object, cb->GetCallbacks(), cb);
else
BNDebuggerSetDebuggerUICallbacks(m_object, nullptr, nullptr);
}


Expand Down
5 changes: 4 additions & 1 deletion core/debuggercontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4757,7 +4757,10 @@ Ref<Settings> DebuggerController::GetAdapterSettings()

void DebuggerController::SetDebuggerUICallbacks(BNDebuggerUICallbacks* cb, void* ctxt)
{
m_uiCallbacks = std::make_unique<DebuggerUICallbacks>(cb, ctxt);
if (cb)
m_uiCallbacks = std::make_unique<DebuggerUICallbacks>(cb, ctxt);
else
m_uiCallbacks.reset();
}


Expand Down
3 changes: 3 additions & 0 deletions ui/ui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1709,6 +1709,9 @@ DebuggerUI::DebuggerUI(UIContext* context, DebuggerControllerRef controller) :

DebuggerUI::~DebuggerUI()
{
// Unregister UI callbacks from the controller before deleting them, so the controller
// does not invoke a dangling callback if events arrive after the UI is destroyed.
m_controller->SetDebuggerUICallbacks(nullptr);
if (m_uiCallbacks)
{
delete m_uiCallbacks;
Expand Down