Conversation
… tenacity for retrying mechanism
fcogidi
reviewed
Jan 29, 2026
Collaborator
fcogidi
left a comment
There was a problem hiding this comment.
A couple of comments:
- Will you switch to
google-adklater since Amrit and I are using that? Asking 'cause the langfuse integration may be different for that. - The
langfuse_uploadscript may be general enough to be in theaieng-eval-agentspackage
Collaborator
Author
Yes. I will have one more PR that I will put out on monday with the trajectory evals and next in line is the move to google-adk.
Good point. I'm planning to move things around in follow up PRs as well and will keep that in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding Langfuse integration code and adding an evaluation script to the report generation agent.
Clickup Ticket(s): NA
Type of Change
Changes Made
langfuse.pyfileFor an example of how the evaluation results are looking like:
https://us.cloud.langfuse.com/project/cmkwsswke005dad07gxujnipq/datasets/cmkyev4nd000nad084ds2xm30/runs/27328bba-9843-4ccb-940f-6fe1b9e3b0ea
Testing
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
Performed manual testing by following the instructions in the README.md file.
Checklist