Add missing minecraft:dyeable item tag for 1.21.5 -> 1.21.4 downgrade#1244
Open
roggy666 wants to merge 1 commit intoViaVersion:masterfrom
Open
Add missing minecraft:dyeable item tag for 1.21.5 -> 1.21.4 downgrade#1244roggy666 wants to merge 1 commit intoViaVersion:masterfrom
roggy666 wants to merge 1 commit intoViaVersion:masterfrom
Conversation
In 1.21.5, the minecraft:dyeable item tag was removed as dyeable property moved into the equippable component system. However, the 1.21.4 client's EquipmentRenderer checks stack.isIn(ItemTags.DYEABLE) before applying dye color to the 3D armor model. Without this tag, colored leather armor appears as default brown on the player model (inventory icon works fine). This adds the dyeable tag with all leather armor item IDs resolved from mapping data in onMappingDataLoaded().
Member
|
Tags for static registries can go into mappings file/repo (like ViaVersion/Mappings@fd1309f) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.21.5, the minecraft:dyeable item tag was removed as dyeable property moved into the equippable component system. However, the 1.21.4 client's EquipmentRenderer checks stack.isIn(ItemTags.DYEABLE) before applying dye color to the 3D armor model. Without this tag, colored leather armor appears as default brown on the player model (inventory icon works fine).
This adds the dyeable tag with all leather armor item IDs resolved from mapping data in onMappingDataLoaded().