set default user via env vars#342
Open
adabru wants to merge 1 commit intoVisual-Regression-Tracker:masterfrom
Open
set default user via env vars#342adabru wants to merge 1 commit intoVisual-Regression-Tracker:masterfrom
adabru wants to merge 1 commit intoVisual-Regression-Tracker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the values
configurable via
.env.I think it's a security issue to have the default user created with default values. Without changing it from the start, I would need to locally change the credentials before I open up the server.
Related issues: Visual-Regression-Tracker/Visual-Regression-Tracker#114, #273 (comment)
@monotek @Thanoonazad
Related PR: Visual-Regression-Tracker/Visual-Regression-Tracker#476