Fix some Closure warnings in Emscripten builds#5075
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Sep 22, 2022
Merged
Fix some Closure warnings in Emscripten builds#5075kripken merged 2 commits intoWebAssembly:mainfrom
kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
Contributor
Author
|
Seems the temporary
Fine with what you folks decide, just need to know whether to revert the workaround here :) |
Member
|
This seems good for binaryen. Yeah, as you said, the general issue remains in emscripten, which we need to figure out - I worry other projects will hit this too. But for binaryen I think we're good now. |
kripken
added a commit
that referenced
this pull request
Sep 22, 2022
This was referenced Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructs Closure about the types in play so the warnings go away.
Didn't encounter the externs warning regarding the. Generally it looks that we could refactor the code slightly to useWebAssemblyobject (need to see what CI states)classes, then we'd not need to annotate in comments so much (except the dynamically generated expression methods).Related #5062
Update: Seen the
WebAssemblyobject externs warning now, which might require a fix to the externs provided by Emscripten.