Reject empty quoted identifiers in parser#8357
Open
stevenfontanella wants to merge 1 commit intomainfrom
Open
Conversation
stevenfontanella
force-pushed
the
fix-id-wast
branch
3 times, most recently
from
4c35084 to
2bbe6ed
Compare
stevenfontanella
force-pushed
the
fix-id-wast
branch
from
2bbe6ed to
f1fd8f2
Compare
tlively
approved these changes
Feb 23, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Sad that we didn't catch this requirement in time to push back on it back when it was introduced :( It's probably not worth trying to do anything about now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8261.
""previously parsed successfully as a name which doesn't match the spec. Change the code to fail to parse this case. Fixes id.wast spec test.