Reland: Improve Benchmark constructor and instance variables #255 #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
camillobruni
commented
Jan 19, 2026
camillobruni
commented
- Use plan as options bag for constructor arguments
- Prefix "protected" instance variables with "_"
- Rename Benchmark.preload to Benchmark._preloadEntries
- Move iteration and worstCase count processing to the Benchmark class
- Add files and preloadEntries getters so we can override it in GroupedBenchmark
- Rename plan.arguments to plan.args due to "argument" being a reserved word
- Rename WasmLegacyBenchmark to AsyncWasmLegacyBenchmark
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Let's reland this independently from the preload refactoring. |
danleh
approved these changes
Jan 19, 2026
Contributor
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
LGTM with one small thing.
Also to document and double check the background / high-level idea: #262 reverted these changes (among others) but we assume these changes here should not affect performance, since they are small renames and moves of functions, but not fundamentally changing preloading, unlike #251.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.