Allow re-resolve script to work with systemd netdev#2
Open
jisakiel wants to merge 1 commit intoWireGuard:masterfrom
Open
Allow re-resolve script to work with systemd netdev#2jisakiel wants to merge 1 commit intoWireGuard:masterfrom
jisakiel wants to merge 1 commit intoWireGuard:masterfrom
Conversation
Trivial changes that enable parsing the slightly modified systemd netdev format, as documented on https://www.freedesktop.org/software/systemd/man/systemd.netdev.html
zx2c4-bot
force-pushed
the
master
branch
6 times, most recently
from
d171082 to
26683f6
Compare
zx2c4-bot
force-pushed
the
master
branch
9 times, most recently
from
542b7c0 to
4ad6d0d
Compare
zx2c4-bot
force-pushed
the
master
branch
3 times, most recently
from
c39c2ea to
ab264f7
Compare
iTrooz
added a commit
to iTrooz/wireguard-tools
that referenced
this pull request
Apr 6, 2025
…k for routing rationale: Using an Endpoint that is part of a network in AllowedIPs (e.g. Endpoint=162.12.13.1 and AllowedIPs=162.12.13.0/24) will cause a looping route when enabling a wireguard connection, because of the routes created by AllowedIPs values. This could be solved using the more advanced fwmark-based routing (that you describe as "Improved Rule-based Routing"), but it only takes effect when AllowedIPs contains 0.0.0.0/0. This patch allow users to override that behaviour in a simply way. This patch does not fix the root problem, which could be addressed in one of the following ways: - Finding Endpoints that are part of networks present in AllowedIPs, and only enabling fwmark routing for them - Always use fwmark routing, even if we don't need it I do not have enough knowledge to choose which option to implement (although I prefer WireGuard#2 because of implementation simplicity). I would like to submit another patch for this, but I will need guidance on what option to choose.
zx2c4-bot
force-pushed
the
master
branch
2 times, most recently
from
4574b8e to
0b7d982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial changes that enable parsing the slightly modified systemd netdev format, as documented on https://www.freedesktop.org/software/systemd/man/systemd.netdev.html
Tested in my box against /etc/systemd/network/wg0.netdev with bash -x