-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Block Supports: Add presets to dimension block supports #10628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Supports: Add presets to dimension block supports #10628
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
182cc77 to
8737c71
Compare
andrewserong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good — looks like there's just one issue to fix up (I've left a comment), but when I updated the width object locally, everything tested well. Once that's sorted I think this will be good to land (and the preceding two PRs that this builds on).
Left a couple of tiny nits re: the tests, just if we should ensure we add both width and height in the test cases, rather than just using one of them. Not a blocker at all, though.
8737c71 to
3ae54c3
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I ran out of time to test this properly, sorry, but it's rebased and I addressed the feedback. |
andrewserong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…presets - Added height dimension preset to the style engine test cases. - Updated expected CSS output to reflect the inclusion of height in the style engine configuration. - Modified theme JSON tests to incorporate height dimension preset for consistency in styling.
… theme JSON tests.
7a2c7a0 to
a3d7918
Compare


Warning
This PR depends on #10470 and #10474 and should be rebased and merged after them.
Trac ticket: https://core.trac.wordpress.org/ticket/64413
This PR brings the changes from the following Gutenberg PRs to core:
WordPress/gutenberg#73811
Description
Adds support for preset dimensions values to be defined within theme.json and used across block supports such as; width, min-height etc.
Testing
dimensionSizespresets to your theme.jsonThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.