-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Remove IE support from Twenty Twenty-One #10857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+17
−9,264
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cf5fe1b
Update `functions.php` using parts of `64278.diff`
sabernhardt 2b61a47
Remove contents of `polyfills.js`
sabernhardt bcd02de
Remove contents of `ie.scss`
sabernhardt 67b5c18
Remove IE editor stylesheet from theme setup and deprecate `is-IE` cl…
sabernhardt 102de67
Remove IE stylesheets from `package.json` build process
sabernhardt 6f54fd3
Remove `ie` from `style.scss`
sabernhardt e302cdc
Remove contents of `ie.css`
sabernhardt 5448d0c
Remove contents of `ie-editor.css`
sabernhardt ecffacf
Empty contents of `ie.css.map`
sabernhardt 13bdbd5
Update `style.css`
sabernhardt 59fa06f
Update `style-rtl.css`
sabernhardt f065bf2
Update `style.css.map`
sabernhardt 58a9db8
Merge branch 't21-remove-ie-support' of https://github.com/sabernhard…
sabernhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
2,669 changes: 1 addition & 2,668 deletions
2,669
src/wp-content/themes/twentytwentyone/assets/css/ie-editor.css
Large diffs are not rendered by default.
Oops, something went wrong.
6,332 changes: 1 addition & 6,331 deletions
6,332
src/wp-content/themes/twentytwentyone/assets/css/ie.css
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
47 changes: 1 addition & 46 deletions
47
src/wp-content/themes/twentytwentyone/assets/js/polyfills.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1 @@ | ||
| /** | ||
| * File polyfills.js. | ||
| * | ||
| * Polyfills for IE11. | ||
| */ | ||
|
|
||
| /** | ||
| * Polyfill for Element.closest() because we need to support IE11. | ||
| * | ||
| * @since Twenty Twenty-One 1.0 | ||
| * | ||
| * @see https://developer.mozilla.org/en-US/docs/Web/API/Element/closest | ||
| */ | ||
| if ( ! Element.prototype.matches ) { | ||
| Element.prototype.matches = Element.prototype.msMatchesSelector || Element.prototype.webkitMatchesSelector; | ||
| } | ||
|
|
||
| if ( ! Element.prototype.closest ) { | ||
| Element.prototype.closest = function( s ) { | ||
| var el = this; | ||
| do { | ||
| if ( Element.prototype.matches.call( el, s ) ) { | ||
| return el; | ||
| } | ||
| el = el.parentElement || el.parentNode; | ||
| } while ( el !== null && el.nodeType === 1 ); | ||
| return null; | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Polyfill for NodeList.foreach() because we need to support IE11. | ||
| * | ||
| * @since Twenty Twenty-One 1.0 | ||
| * | ||
| * @see https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach | ||
| */ | ||
| if ( window.NodeList && ! NodeList.prototype.forEach ) { | ||
| NodeList.prototype.forEach = function( callback, thisArg ) { | ||
| var i; | ||
| thisArg = thisArg || window; | ||
| for ( i = 0; i < this.length; i++ ) { | ||
| callback.call( thisArg, this[i], i, this ); | ||
| } | ||
| }; | ||
| } | ||
| // Polyfills for IE11 have been removed. |
65 changes: 1 addition & 64 deletions
65
src/wp-content/themes/twentytwentyone/assets/sass/07-utilities/ie.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,64 +1 @@ | ||
| .is-IE { | ||
|
|
||
| &.is-dark-theme { | ||
| color: #fff; | ||
|
|
||
| *, | ||
| a, | ||
| .site-description, | ||
| .entry-title, | ||
| .entry-footer, | ||
| .widget-area, | ||
| .post-navigation .meta-nav, | ||
| .footer-navigation-wrapper li a:link, | ||
| .site-footer > .site-info, | ||
| .site-footer > .site-info a, | ||
| .site-footer > .site-info a:visited { | ||
| color: #fff; | ||
| } | ||
|
|
||
| .sub-menu-toggle svg, | ||
| .sub-menu-toggle path, | ||
| .post-navigation .meta-nav svg, | ||
| .post-navigation .meta-nav path { | ||
| fill: #fff; | ||
| } | ||
|
|
||
| .primary-navigation > div > .menu-wrapper > li > .sub-menu li { | ||
| background: #000; | ||
| } | ||
|
|
||
| &.primary-navigation-open { | ||
| @include media(mobile-only) { | ||
|
|
||
| .primary-navigation > .primary-menu-container, | ||
| .menu-button-container { | ||
| background-color: #000; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .skip-link:focus { | ||
| color: #21759b; | ||
| } | ||
| } | ||
|
|
||
| .navigation .nav-links { | ||
| display: block; | ||
| } | ||
|
|
||
| .post-thumbnail .wp-post-image { | ||
| min-width: auto; | ||
| } | ||
|
|
||
| .wp-block-group { | ||
|
|
||
| &:before, | ||
| &:after { | ||
| content: ""; | ||
| display: block; | ||
| clear: both; | ||
| } | ||
| } | ||
|
|
||
| } | ||
| // IE11 styles are removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shell we remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not to remove any files, though removing an unused
.scssfile theoretically should be safe.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've generally been consistent about not removing files, so we might as well remain consistent. It can still be useful documentation for somebody.