Skip to content

Conversation

@bluefuton
Copy link

@bluefuton bluefuton commented Feb 12, 2026

Summary

  • IXR_Client accesses $bits['host'] from parse_url() without checking if the key exists, which can trigger an undefined index warning for URLs without a host component (e.g. relative paths).
  • Uses the null coalescing operator (??) to fall back to an empty string, consistent with how port and path are already handled on the adjacent lines.
  • Adds a unit test to verify no error is triggered when the host is missing.

Trac ticket

https://core.trac.wordpress.org/ticket/64635

Test plan

  • Verify IXR_Client no longer triggers an undefined index warning when instantiated with a URL lacking a host component
  • Run npm run test:php -- --filter test_ixr_client_does_not_error_when_host_is_ missing and confirm the test passes

`parse_url()` does not always return a `host` key (e.g. for relative
paths). Use the null coalescing operator to fall back to an empty string,
consistent with how `port` and `path` are already handled.

Adds a unit test to verify no error is triggered when the host is missing.

Trac: https://core.trac.wordpress.org/ticket/64635
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bluefuton, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter
Copy link
Member

Should the same fix be applied to WP_HTTP_IXR_Client?

$this->scheme = $bits['scheme'];
$this->server = $bits['host'];
$this->port = $bits['port'] ?? $port;
$this->path = ! empty( $bits['path'] ) ? $bits['path'] : '/';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants