Skip to content

Interactivity API: Update loading bar to use private router store#10942

Closed
luisherranz wants to merge 1 commit intoWordPress:trunkfrom
luisherranz:interactivity-router-use-private-store
Closed

Interactivity API: Update loading bar to use private router store#10942
luisherranz wants to merge 1 commit intoWordPress:trunkfrom
luisherranz:interactivity-router-use-private-store

Conversation

@luisherranz
Copy link
Member

The Interactivity Router store contains internal properties (state.navigation.hasStarted, state.navigation.hasFinished) that are not part of the public API. Gutenberg PR #70882 moves these properties to a new private core/router/private store and adds deprecation warnings when they are accessed through the public core/router store.

This PR updates the loading bar markup in WP_Interactivity_API::print_router_markup() to use data-wp-interactive="core/router/private" instead of data-wp-interactive="core/router", so it accesses the private store directly and avoids triggering the deprecation warnings.

Trac ticket: https://core.trac.wordpress.org/ticket/64647
Related Gutenberg PR: WordPress/gutenberg#70882


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@luisherranz luisherranz self-assigned this Feb 16, 2026
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props luisherranz.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61653
GitHub commit: 0b8bc64

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 16, 2026
@luisherranz
Copy link
Member Author

Thanks, Weston! 🙏❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants