Recognize clang targeting Windows as "MinGW like"#2020
Open
fmeum wants to merge 1 commit intoabseil:masterfrom
Open
Recognize clang targeting Windows as "MinGW like"#2020fmeum wants to merge 1 commit intoabseil:masterfrom
clang targeting Windows as "MinGW like"#2020fmeum wants to merge 1 commit intoabseil:masterfrom
Conversation
This is necessary to get abseil to build with https://github.com/cerisier/toolchains_llvm_bootstrapped. The old mappings for MinGW are arguably not semantically correct as MinGW is the runtime/sysroot, not the compiler, but are left in place for backwards compatibility.
Author
|
FYI @meteorcloudy |
derekmauro
reviewed
Feb 25, 2026
| match_any = [ | ||
| ":mingw_unspecified_compiler", | ||
| ":mingw-gcc_compiler", | ||
| ":windows-clang", |
Member
There was a problem hiding this comment.
The seems to be a hack. In some cases hacks are fine, but there is no comment or any trace for a future reader that explains why this strange line is appearing here. Can you explain precisely what the problem is? Would renaming this group make it more clear what its purpose is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to get abseil to build with https://github.com/cerisier/toolchains_llvm_bootstrapped. The old mappings for MinGW are arguably not semantically correct as MinGW is the runtime/sysroot, not the compiler, but are left in place for backwards compatibility.