Skip to content

Middleware for caching succesful GET responses with Redis automatically#630

Merged
JohnTitor merged 10 commits intoactix:mainfrom
bangbaew:master
Feb 1, 2026
Merged

Middleware for caching succesful GET responses with Redis automatically#630
JohnTitor merged 10 commits intoactix:mainfrom
bangbaew:master

Conversation

@bangbaew
Copy link
Contributor

@bangbaew bangbaew commented Jul 24, 2023

Close #627

@bangbaew bangbaew changed the title Middleware for auto caching succesful GET responses with redis Middleware for caching succesful GET responses with Redis automatically Jul 24, 2023
bangbaew and others added 3 commits July 24, 2023 21:13
If no-store directive is specified, don't get Redis connection so it won't have any bottleneck connecting to the Redis server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests would be good if you feel like the challenge. We run redis in CI for other examples so should be easy enough to copy those.

@bangbaew
Copy link
Contributor Author

bangbaew commented Aug 5, 2023

added dependency versions and removed dead code

@robjtede
Copy link
Member

I'd be interested to merge this if we can fix the CI.

@JohnTitor JohnTitor dismissed robjtede’s stale review February 1, 2026 08:43

Addressed, now it passes CI

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor added this pull request to the merge queue Feb 1, 2026
Merged via the queue into actix:main with commit a507cf2 Feb 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add caching example

3 participants