Add Windows artifact build using Linux cross compile#7
Open
udif wants to merge 2 commits intoadmesh:masterfrom
Open
Add Windows artifact build using Linux cross compile#7udif wants to merge 2 commits intoadmesh:masterfrom
udif wants to merge 2 commits intoadmesh:masterfrom
Conversation
No artifacts saved, just check if there are build errors.
udif
force-pushed
the
pr_build
branch
3 times, most recently
from
f41ad6f to
7d84d33
Compare
Author
|
I've edited the original PR comment, and I think this PR is ready for integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires the following PR to be applied before it can be used: admesh/stlsplit#3
At the moment, it pulls my fork of stlsplit, that adds a static library build option.
As part of this PR There is also a Linux build script, but it doesn't generate artifacts (I found this less important for Linux).
It is useful because it will complain if any commit will break the project.
I also used it as the baseline for the Linux to Windows cross compile version.