fix(RAC): use ICB size as the fallback value for visual viewport#9384
Merged
snowystinger merged 3 commits intoadobe:mainfrom Jan 30, 2026
Merged
fix(RAC): use ICB size as the fallback value for visual viewport#9384snowystinger merged 3 commits intoadobe:mainfrom
snowystinger merged 3 commits intoadobe:mainfrom
Conversation
5 tasks
5 tasks
Contributor
Author
|
Edited: I've updated the PR description. Original post@snowystinger This PR is primarily about correctness. It may not address any real-world issues because the VisualViewport is widely supported today. |
# Conflicts: # packages/@react-aria/utils/src/useViewportSize.ts
snowystinger
approved these changes
Jan 8, 2026
LFDanLu
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the specification, the visual viewport size excludes the scrollbar. Instead of
window.innerWidth/Height, the fallback value should bedocument.documentElement.clientWidth/Height, which is the same as the ICB size and almost equivalent to the visual viewport size, which excludes the scrollbar.It's mainly a fix about code correctness, as the
VisualViewportis widely supported today.See: https://drafts.csswg.org/cssom-view/#visualViewport
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: