fix: apply hover state on Tags with href#9750
Merged
yihuiliao merged 4 commits intoadobe:mainfrom Mar 6, 2026
Merged
Conversation
reidbarber
approved these changes
Mar 6, 2026
yihuiliao
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9507
Adding the suggested fix from the above issue to the TagGroup aria component. Added a new test to cover the case where a Tag in a TagGroup has an href and is being hovered. No documentation or accessibility changes seem to be needed at the time
Before:
tag-hover-before.mp4
After:
tag-hover-after.mp4
✅ Pull Request Checklist:
📝 Test Instructions:
Tested with the existing "Tag Group Example" under the aria components Storybook
data-hoveredpropertyBefore code changes, the
data-hoveredattribute will never be displayed on the tag. After changes,data-hovered=trueshould display while the tag is hovered, and the attribute should disappear once no longer hovering.Note: I added background color styles for local testing to ensure that was still working properly. This can be done by updating the following line:
react-spectrum/packages/react-aria-components/stories/TagGroup.stories.tsx
Line 78 in ee49fdb
to be this instead:
🧢 Your Project:
None