fix: update serialization for DestinationDefinitionRead object#3
Open
wkargul wants to merge 1 commit intoagyleOS:masterfrom
Open
fix: update serialization for DestinationDefinitionRead object#3wkargul wants to merge 1 commit intoagyleOS:masterfrom
wkargul wants to merge 1 commit intoagyleOS:masterfrom
Conversation
Contributor
Author
|
Hi @omid, please take a look on that :) |
Member
|
Please use the just file we have to do these replacements. |
Member
|
Please also link to the code in airbyte with these specs, for |
Contributor
Author
|
Sure thing! I'll tweak it as soon as I can find a moment this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Serialization for DestinationDefinitionRead Object
Summary
This PR addresses serialization issues in the
DestinationDefinitionReadobject. The serialized JSON response was missing thecustomfield and therelease_datewas being deserialized incorrectly as aStringinstead ofVec<u16>.Changes
customfield to serialized outputrelease_dateto useVec<u16>instead ofStringExample Serialized Response
{ "destinationDefinitionId": "65de8962-48c9-11ee-be56-0242ac120002", "name": "Milvus", "dockerRepository": "airbyte/destination-milvus", "dockerImageTag": "0.0.1", "documentationUrl": "https://docs.airbyte.com/integrations/destinations/milvus", "icon": "<svg...></svg>", "protocolVersion": "0.2.0", "custom": false, "supportLevel": "community", "releaseStage": "alpha", "releaseDate": [2023, 8, 15], "supportsDbt": false, "normalizationConfig": { "supported": false } }Next Steps
After merging this PR, a new version of the library should be built and published to crates.io.
Please review and if all looks good, proceed with merging.