feat: use object-style params for Solana DAS endpoints #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `paramStructure: by-name` to all 12 DAS methods so the rendered
docs produce `params: { ... }` instead of `params: [...]`.
- Add missing primary fields (id, ids, ownerAddress, mint, etc.) and
`required` arrays to config schemas in asset.yaml
- Create GetAssetProofParams / GetAssetProofsParams schemas
- Collapse multi-param methods into a single config param
- Update examples to use full object values
Co-Authored-By: Claude <noreply@anthropic.com>
🌿 Documentation Preview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
paramStructure: by-nameto all 12 Solana DAS methods so the docs site renders"params": { ... }instead of"params": [...]id,ids,ownerAddress,mint, etc.) andrequiredarrays to config schemas inasset.yamlGetAssetProofParamsandGetAssetProofsParamsschemas for methods that previously had no config objectCompanion PR: OMGWINNING/docs-site (rendering support for
paramStructure: by-name)Test plan
pnpm generate:rpc— confirmparamStructure: "by-name"appears in generatedsolana-das.jsonfor all 12 methodsownerAddressinGetAssetsByOwnerConfig)