Open
Conversation
…and adding new logging on crawldir signed usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new signed URL file upload workflow as an alternative to the existing direct ingest endpoint.
This is an optional flag that speeds up uploads and makes them more reliable, specifically for Aleph Pro. But OpenAleph may choose to implement this as well.
Instead of a single multipart POST to
/collections/{id}/ingest, the new flow works in three steps:/collections/{id}/document.This is opt-in via a
--signed-urlflag on the CLIcrawldircommand, and asigned_url=Trueparameter on theAlephAPI.ingest_upload()Python method.The old ingest path remains the default so nothing breaks for existing users.
New unit and integration tests were added and all pass.