Open
Conversation
alexandraBara
requested changes
Feb 24, 2026
Collaborator
|
When there are no RDMA deviced (Infiniband etc), i think we should either give a warning and say 'No RDMA devices found' or NOT_RAN? And the analzyer should definitely not run on an empty dataset either. See below: and this definitely needs to be a warning not info: 2026-02-27 10:01:04 CST INFO nodescraper | (RdmaPlugin) RDMA statistics list is empty* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-scraper run-plugins RdmaPluginGenerate reference plugin
node-scraper --gen-reference-config run-plugins RdmaPluginUse reference config for run
node-scraper --plugin-configs <generated json config path>