fix: OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS env var silently ignored #12869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OPENCODE_SERVER_PASSWORD is set, the auth middleware was applied to all routes including /global/health. Health check endpoints should be accessible without authentication so that monitoring tools and load balancers can verify the server is running. Skip the basicAuth check when the request path is /global/health. Fixes anomalyco#12805
Sync the region prefix list and region checks in getSmallModel() with the existing getModel() logic. The crossRegionPrefixes array was missing jp., apac., and au. entries, and the region check only handled us and eu, causing APAC regions (ap-northeast-1, ap-southeast-2, etc.) to fall through without proper cross-region prefix mapping. Fixes anomalyco#12824
The bash default timeout env var was being silently ignored because it was evaluated once at module load time as a static const. Convert it to a dynamic getter (via Object.defineProperty) and evaluate lazily in the bash tool so the env var is read when the tool executes, not when the module initializes. Fixes anomalyco#12762
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Author
|
Closing to resubmit cleanly — this branch accidentally picked up changes from other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MSenvironment variable is silently ignoredconstat module load time, so the env var value was captured once (asundefined) and never re-readObject.defineProperty(consistent with other dynamic flags likeOPENCODE_CLIENT,OPENCODE_CONFIG_DIR)DEFAULT_TIMEOUTin the bash tool from a module-level constant to a lazy function call so it reads the flag value at execution timeTest plan
OPENCODE_EXPERIMENTAL_BASH_DEFAULT_TIMEOUT_MS=5000and verify bash commands time out after 5 secondsFixes #12762