fix: track session status for prompt_async and guard against missing agent #12870
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OPENCODE_SERVER_PASSWORD is set, the auth middleware was applied to all routes including /global/health. Health check endpoints should be accessible without authentication so that monitoring tools and load balancers can verify the server is running. Skip the basicAuth check when the request path is /global/health. Fixes anomalyco#12805
Sync the region prefix list and region checks in getSmallModel() with the existing getModel() logic. The crossRegionPrefixes array was missing jp., apac., and au. entries, and the region check only handled us and eu, causing APAC regions (ap-northeast-1, ap-southeast-2, etc.) to fall through without proper cross-region prefix mapping. Fixes anomalyco#12824
…agent Set session status to busy immediately when prompt_async is called and ensure it resets to idle on failure. Previously the fire-and-forget prompt left status permanently unknown because errors were unhandled and the initial busy transition was never emitted. Also add a null check for the agent lookup in createUserMessage to prevent TypeError when an invalid agent name is provided. Fixes anomalyco#12860
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Author
|
Closing to resubmit cleanly — this branch accidentally picked up unrelated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
busyimmediately whenprompt_asyncis called, so/session/statuscorrectly reflects the active state instead of remainingunknown.catch()handler on the fire-and-forget prompt promise to reset status toidleon failure and log the error, preventing the status from getting permanently stuckAgent.get()increateUserMessageto preventTypeError: undefined is not an object (evaluating 'agent.model')when an invalid agent name is providedTest plan
POST /:sessionID/prompt_asyncand verify/session/statusreturnsbusyimmediatelyidleafter the prompt completesidleFixes #12860