fix(core): handle macro data as string in built artifacts#8828
Closed
junmediatek wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(core): handle macro data as string in built artifacts#8828junmediatek wants to merge 1 commit intoanomalyco:devfrom
junmediatek wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
Cloud you help to review this PR 74fa97e |
2a38b10 to
74fa97e
Compare
Contributor
Author
|
Could you help to check this PR 74fa97e ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds check for string type to handle Bun macros inlined at build time.
Changes
Modified the type check to include both function and string types:
Context
When Bun macros are enabled during compilation, the
data()function may be executed and inlined as a string literal in the built artifacts. The original code only checked for function type, missing the string case.