test(fixture): isolate test git repos from developer global hooks #8898
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test isolation by preventing global git configuration and hooks from interfering with test execution. Developers with global git hooks (e.g., enforcing commit sign-offs) were experiencing test failures because the test fixture git repositories inherited those global settings.
Changes:
- Configured isolated user identity for test git repositories
- Redirected git hooks to an empty directory to bypass global hooks
- Added comments explaining the isolation strategy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 17, 2026
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
Tests could fail for developers with global git hooks (e.g., sign-off requirements). Test fixtures now use isolated git config and an empty hooks directory. Signed-off-by: assagman <ahmetsercansagman@gmail.com>
Address PR review: make config scope explicit for clarity. Signed-off-by: assagman <ahmetsercansagman@gmail.com>
assagman
force-pushed
the
test/fixture-git-hook
branch
from
a899ca5 to
5179f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests could fail for developers with global git hooks (e.g., sign-off requirements). Test fixtures now use isolated git config and an empty hooks directory.
Fixes #8899