Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
This PR appears to be directly related as it also addresses bumping bun to version 1.3.6, which is the core issue your PR is addressing. You should verify if #8865 is still open/active and whether it already resolves the bun 1.3.6 update for your use case. |
gigamonster256
force-pushed
the
push-plmyzrwyzkus
branch
from
c2aa186 to
b5873e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using bun 1.3.5 from nixpkgs, opencode appears to not build a binary compatible with base M series CPUs. (some sort of issue with baseline bun vs with extensions perhaps? the baffling thing is that my M1 macbook pro cannot build opencode but builds work in CI which use M1 processors for macos-latest - perhaps its a base vs pro vs max issue?
Recent work allows bun version relaxation and as such, it is appropriate to bump flake.lock to a nixpkgs checkout containing bun 1.3.6 - allowing opencode's dev branch to be built for all supported platforms*
*tested x86_64-linux and aarch64-darwin locally
fixes #9285