AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer#1461
AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer#1461grigoni wants to merge 1 commit intoapache:mainfrom
Conversation
use StringBuilder best practice when concatenating avoid concatenation in logging some typo fixing
|
@grigoni yes I started to review it. Generally speaking, I'm not a big fan of large PR for code cleanup (when generated by tool or not). It's long to review (it touches different part of the code) and side effects can happen (for instance, using a not expected locale, ...). So, instead of a super large PR changing everything at once, I would split into smaller chuncks. That said for this PR, at first glance, it looks good, but I still have to do a new pass. |
|
@jbonofre |
|
@grigoni it's ok. Don't worry. I will do a pass. |
|
Breaking up the commits by type of fix and maven module is helpful in the event something need to be reverted. |
|
closing this PR, current code base does not need this changes |
second round about StringBuffer usage
java.nio.charset.StandardCharsetsfor getBytes...length() > 0"0123456789".repeat(Math.max(0, loopSize));instead of a loop with a SBsee https://issues.apache.org/jira/browse/AMQ-9732