AMQ-9775: Add the maxBrowsePageSize attribute to the JMX destination MBean#1500
AMQ-9775: Add the maxBrowsePageSize attribute to the JMX destination MBean#1500jeanouii merged 1 commit intoapache:mainfrom
Conversation
|
I can add a test about this new JMX attribute. |
|
@jbonofre please add a test for queue AND topic subscription recovery policy to catch regression |
|
The ticket refers to being able to provide a configuration option (maxBrowsePageSize), but the PR also includes the ability to update it. If this is intended, then we probably need to update the ticket and check the impact of updating the property at runtime. If it's not intended, we can I think remove the setter and not necessarly have tons of tests, it's read-only. |
|
My bad: the intent is really to just read (not update). I'm updating the PR accordingly. |
|
@jeanouii updated to just have read attribute. |
jeanouii
left a comment
There was a problem hiding this comment.
There is zero risk adding read-only feature to this property.
If we had to update the property, it would require checking the side effects and creating tests for regression. Other here, the tests would make very little added value.
This PR adds the
maxBrowsePageSizeattribute to the JMX destination MBean.As described in the Jira (AMQ-9775), the
maxBrowsePageSizeproperty can be set in the destination policies, in the broker.I have several use cases where client applications are interested to get this metric (via JMX or REST with Jolokia):