Use unsigned long integers for computing bit-length of fixed-width types via the CData ABI#251
Merged
CurtHagenlocher merged 2 commits intoapache:mainfrom Feb 2, 2026
Conversation
…ediate value when importing very big array via CData ABI
adamreeve
reviewed
Feb 2, 2026
Co-authored-by: Adam Reeve <adreeve@gmail.com>
Contributor
Author
|
Thank you. I misunderstood the argument being made, not that the underlying hardware was not 8-bit byte compliant but that the library defined types did not enforce that invariant. |
adamreeve
approved these changes
Feb 2, 2026
Contributor
adamreeve
left a comment
adamreeve
left a comment
There was a problem hiding this comment.
Thanks for fixing this @mobiusklein!
I'll leave this open for a little while longer in case anybody else has a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Uses unsigned 64-bit integers to compute the intermediate bit length of an array to avoid arithmetic overflow.
I could factorize this expression differently to avoid the casts, but I didn't think this was a sufficiently heavy code path that it'd need more attention.
Closes #250 .