Skip to content

Fix error with Boost::headers when building with Thrift #48852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RUSLoker wants to merge 1 commit into
base: maint-22.0.0.1-r
Choose a base branch
from
Open

Fix error with Boost::headers when building with Thrift #48852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,7 @@ if(ARROW_USE_BOOST)
set(Boost_USE_STATIC_LIBS ON)
endif()
if(ARROW_BOOST_REQUIRE_LIBRARY)
set(ARROW_BOOST_COMPONENTS filesystem system)
set(ARROW_BOOST_COMPONENTS filesystem system headers)
if(ARROW_FLIGHT_SQL_ODBC AND MSVC)
list(APPEND ARROW_BOOST_COMPONENTS locale)
endif()
Expand Down Expand Up @@ -1817,6 +1817,8 @@ function(build_thrift)
if(BOOST_VENDORED)
target_link_libraries(thrift PUBLIC $<BUILD_LOCAL_INTERFACE:Boost::headers>)
target_link_libraries(thrift PRIVATE $<BUILD_LOCAL_INTERFACE:arrow::Boost::locale>)
elseif (Boost_FOUND)
target_link_libraries(thrift PUBLIC $<BUILD_LOCAL_INTERFACE:Boost::headers>)
endif()

add_library(thrift::thrift INTERFACE IMPORTED)
Expand Down