GH-49452: [Python] Reintroduce docstring injection for stubfiles#49453
Open
rok wants to merge 3 commits intoapache:mainfrom
Open
GH-49452: [Python] Reintroduce docstring injection for stubfiles#49453rok wants to merge 3 commits intoapache:mainfrom
rok wants to merge 3 commits intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: Python
Component: Documentation
awaiting committer review
Member
Author
|
@raulcd this is ready for review |
rok
force-pushed
the
docstring-injection
branch
from
2f0f841 to
f885111
Compare
Member
|
@github-actions crossbow submit wheel*-cp313-* |
|
Revision: f885111 Submitted crossbow builds: ursacomputing/crossbow @ actions-c1678cd8dd
|
github-actions
bot
added
awaiting changes
rok
force-pushed
the
docstring-injection
branch
from
d638b95 to
10509c4
Compare
Member
Author
|
@github-actions crossbow submit wheel*-cp313-* |
|
Revision: 10509c4 Submitted crossbow builds: ursacomputing/crossbow @ actions-f3f679ce77
|
rok
force-pushed
the
docstring-injection
branch
from
10509c4 to
e4903eb
Compare
Member
Author
|
@github-actions crossbow submit wheel*-cp313-* |
|
Revision: e4903eb Submitted crossbow builds: ursacomputing/crossbow @ actions-a33b20ecd0
|
Member
Author
|
@raulcd the docstring presence check was apparently too strict. I think this is ready for review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Warning: should not be merged before #49259.
See #49452 and #48618
What changes are included in this PR?
Adds a wheel build time script to populate stubfiles with runtime docstrings.
Are these changes tested?
Not yet.
Are there any user-facing changes?
Users will get docstrings.