GH-49477: [C++][Parquet] Fix multiplication overflow in PLAIN BYTE_ARRAY decoder#49478
Merged
pitrou merged 1 commit intoapache:mainfrom Mar 11, 2026
Merged
GH-49477: [C++][Parquet] Fix multiplication overflow in PLAIN BYTE_ARRAY decoder#49478pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
pitrou
force-pushed
the
gh49477-pq-mul-overflow
branch
from
5051ed0 to
122177c
Compare
pitrou
requested review from
assignUser,
jonkeane,
kou,
raulcd and
wgtmac
as code owners
Member
Author
|
#49451 will have to be merged before so that CI can pass. |
pitrou
force-pushed
the
gh49477-pq-mul-overflow
branch
from
122177c to
1d355a9
Compare
…YTE_ARRAY decoder
pitrou
force-pushed
the
gh49477-pq-mul-overflow
branch
from
1d355a9 to
ddfb3a0
Compare
Member
Author
|
@github-actions crossbow submit fuzz |
pitrou
added
the
Critical Fix
|
Revision: ddfb3a0 Submitted crossbow builds: ursacomputing/crossbow @ actions-7b0a04b78f
|
wgtmac
approved these changes
Mar 11, 2026
github-actions
bot
added
awaiting committer review
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9b134ec. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Issue found by OSS-Fuzz: https://issues.oss-fuzz.com/issues/489948953
Are these changes tested?
By added regression file.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix". Signed integer overflow is undefined behavior, so this could result in any kind of misbehavior.