Using OpenTelemetry instrumentation via Spring Boot starter and OpenTelemetry2#22675
Using OpenTelemetry instrumentation via Spring Boot starter and OpenTelemetry2#22675beskow wants to merge 4 commits intoapache:mainfrom
Conversation
…s an alternative to the OpenTelemetry agent.
188f98a to
f9e3531
Compare
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
All tested modules (9 modules)
|
squakez
left a comment
There was a problem hiding this comment.
LGTM, just a minor note would be required for compatibility reasons.
| <dependency> | ||
| <groupId>io.opentelemetry.instrumentation</groupId> | ||
| <artifactId>opentelemetry-instrumentation-bom</artifactId> | ||
| <version>2.26.1</version> |
There was a problem hiding this comment.
Probably you want to set here a version compatible with the Opentelemetry dependencies that are used within a given Camel version used. We should add a note.
There was a problem hiding this comment.
Good point, I'll have added that!
There was a problem hiding this comment.
Thanks, but I think that note is not enough. I'm adding a comment inline to show how I think it should be. Feel free to accept the inline change if you want.
There was a problem hiding this comment.
Sure! I had added the same info in the paragraph above, but it might be more clear the way you suggested. Now applied, thanks!
| <dependency> | ||
| <groupId>io.opentelemetry.instrumentation</groupId> | ||
| <artifactId>opentelemetry-instrumentation-bom</artifactId> | ||
| <version>2.26.1</version> |
There was a problem hiding this comment.
Thanks, but I think that note is not enough. I'm adding a comment inline to show how I think it should be. Feel free to accept the inline change if you want.
Co-authored-by: Pasquale Congiusti <pasquale.congiusti@gmail.com>
Description
Document how to configure and use opentelemetry-spring-boot-starter as an alternative to the OpenTelemetry agent (see https://issues.apache.org/jira/browse/CAMEL-23343).
Target
mainbranch)Tracking
Apache Camel coding standards and style
I checked that each commit in the pull request has a meaningful subject line and body.
I have run
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.