chore(deps): Bump httpclient-version from 5.5.2 to 5.6.1#22688
chore(deps): Bump httpclient-version from 5.5.2 to 5.6.1#22688dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
previous PR to bump to 5.6 was closed by @davsclaus #20581 |
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
we are now on SB4 so we can upgrade |
|
🧪 CI tested the following changed modules:
✅ POM dependency changes: targeted tests included Changed properties: httpclient-version Modules affected by dependency changes (20)
Build reactor — dependencies compiled but only changed modules were tested (21 modules)
|
|
HttpCompressionTest needs manual fix/update |
apupier
left a comment
There was a problem hiding this comment.
[camel-http] [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.015 s <<< FAILURE! -- in org.apache.camel.component.http.HttpCompressionTest
[camel-http] [ERROR] org.apache.camel.component.http.HttpCompressionTest.compressedHttpPost -- Time elapsed: 0.013 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <camel rocks!> but was: <null>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:158)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:139)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:201)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:184)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:179)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1188)
at org.apache.camel.component.http.BaseHttpTest.assertBody(BaseHttpTest.java:53)
at org.apache.camel.component.http.HttpCompressionTest.compressedHttpPost(HttpCompressionTest.java:105)
|
there is a swallowed exception: |
|
Note that there is a note in changelog of httpclient that compression mechanism has been modified and now severzl libraries are optional and called by reflction but in theory the gzip format should still be available by default https://github.com/apache/httpcomponents-client/pull/737/changes#diff-a3be7429ae1a366fee7c16707e733d3afd4c5784661985706a77685cdd8be0e3R54 also not that adding commons-compress is not fixing the issue |
|
very likely due to this kind of change https://issues.apache.org/jira/browse/HTTPCLIENT-2409 where the content is ungzipped automatically in some cases (currently readign and tryign to understand it to see what we shoudl do on our side) |
Bumps `httpclient-version` from 5.5.2 to 5.6.1. We were previously basing actions to ungzip and content encoding on headers of the response. It was possible because these headers were previously removed by the client automatically. it is no more the case as the headers are supposed to reflect what the opposite endpoint sent, not the actual current state in httpclient. To know the current state, we need to look to the entity. most important details in https://issues.apache.org/jira/browse/HTTPCLIENT-2409?focusedCommentId=18047208&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18047208 and reading teh whoel discussion can help Updates `org.apache.httpcomponents.client5:httpclient5` from 5.5.2 to 5.6.1 - [Changelog](https://github.com/apache/httpcomponents-client/blob/rel/v5.6.1/RELEASE_NOTES.txt) - [Commits](apache/httpcomponents-client@rel/v5.5.2...rel/v5.6.1) Updates `org.apache.httpcomponents.client5:httpclient5-fluent` from 5.5.2 to 5.6.1 - [Changelog](https://github.com/apache/httpcomponents-client/blob/rel/v5.6.1/RELEASE_NOTES.txt) - [Commits](apache/httpcomponents-client@rel/v5.5.2...rel/v5.6.1) --- updated-dependencies: - dependency-name: org.apache.httpcomponents.client5:httpclient5 dependency-version: 5.6.1 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.httpcomponents.client5:httpclient5-fluent dependency-version: 5.6.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Aurélien Pupier <apupier@ibm.com>
a0b7238 to
8d46dbb
Compare
|
We were previously basing actions to ungzip and content encoding on |
important changes provided since approval
Bumps
httpclient-versionfrom 5.5.2 to 5.6.1.Updates
org.apache.httpcomponents.client5:httpclient5from 5.5.2 to 5.6.1Changelog
Sourced from org.apache.httpcomponents.client5:httpclient5's changelog.
... (truncated)
Commits
4f86ca6HttpClient 5.6.1 release1b2bafeUpdated release notes for HttpClient 5.6.1 release1acf00bFix SCRAM final response handling49549abAuth challenge parsing code improvementfa6b6d7Add missing Javadoc for ConnectionConfig (#820)3de8ad5Fixed DefaultClientTlsStrategy test failures on MacOSc69f38fBug-fix: corrects message exchange cancellation logic in InternalHttpAsyncExe...30386d3HTTPCLIENT-2417 Honor TlsConfig attachment in async connect path9cc45f6HTTPCLIENT-2414 - Fix Basic auth cache scoping across path prefixes (#802)1e01a48HTTPCLIENT-2415: Normalize CookieOrigin path for cookie matching (#803)Updates
org.apache.httpcomponents.client5:httpclient5-fluentfrom 5.5.2 to 5.6.1Changelog
Sourced from org.apache.httpcomponents.client5:httpclient5-fluent's changelog.
... (truncated)
Commits
4f86ca6HttpClient 5.6.1 release1b2bafeUpdated release notes for HttpClient 5.6.1 release1acf00bFix SCRAM final response handling49549abAuth challenge parsing code improvementfa6b6d7Add missing Javadoc for ConnectionConfig (#820)3de8ad5Fixed DefaultClientTlsStrategy test failures on MacOSc69f38fBug-fix: corrects message exchange cancellation logic in InternalHttpAsyncExe...30386d3HTTPCLIENT-2417 Honor TlsConfig attachment in async connect path9cc45f6HTTPCLIENT-2414 - Fix Basic auth cache scoping across path prefixes (#802)1e01a48HTTPCLIENT-2415: Normalize CookieOrigin path for cookie matching (#803)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)