Skip to content

Comments

[CASSANDRA-21093] Custom startup checks plugin#4555

Closed
nickbar01234 wants to merge 1 commit intoapache:trunkfrom
nickbar01234:21093/trunk
Closed

[CASSANDRA-21093] Custom startup checks plugin#4555
nickbar01234 wants to merge 1 commit intoapache:trunkfrom
nickbar01234:21093/trunk

Conversation

@nickbar01234
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

return this;
}

public StartupChecks withExternalTests() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: what's the value in exposing this method ?

is it solely about order versus calls to withTest(StartupCheck)

suggestion: rename for added intuition

Suggested change
public StartupChecks withExternalTests() {
public StartupChecks withServiceLoaderTests() {

@smiklosovic smiklosovic closed this Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants