Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR adds APIs to clone existing offerings - service, system, network, VPC, backup and update certain parameters of the existing offering.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 48.54369% with 583 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.91%. Comparing base (1b0a036) to head (10333df).

Files with missing lines Patch % Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 0.50% 195 Missing and 2 partials ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java 67.68% 115 Missing and 64 partials ⚠️
.../command/admin/network/NetworkOfferingBaseCmd.java 29.64% 129 Missing and 11 partials ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java 48.88% 11 Missing and 12 partials ⚠️
...i/command/admin/backup/CloneBackupOfferingCmd.java 66.00% 17 Missing ⚠️
...i/command/admin/offering/CloneDiskOfferingCmd.java 0.00% 13 Missing ⚠️
...ack/api/command/admin/vpc/CloneVPCOfferingCmd.java 60.00% 10 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12357      +/-   ##
============================================
+ Coverage     17.84%   17.91%   +0.07%     
- Complexity    15980    16163     +183     
============================================
  Files          5929     5942      +13     
  Lines        531084   533360    +2276     
  Branches      64914    65482     +568     
============================================
+ Hits          94783    95577     +794     
- Misses       425686   427023    +1337     
- Partials      10615    10760     +145     
Flag Coverage Δ
uitests 3.45% <ø> (-0.13%) ⬇️
unittests 19.06% <48.54%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from 62368f3 to 3787aaa Compare January 6, 2026 22:39
@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Jan 7, 2026
@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from a5a9eb4 to bb2e90d Compare January 8, 2026 21:49
@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from bb2e90d to 7fd4567 Compare January 8, 2026 21:52
@boring-cyborg boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels Jan 9, 2026
@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make the new if and for blocks separte methods (with clear names please?

@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from a7266b2 to cc4ada0 Compare January 21, 2026 15:26
@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from 5f5147d to 3511525 Compare January 21, 2026 15:44
@Pearl1594 Pearl1594 force-pushed the clone-edit-existing-offerings branch from 1f5796d to 10333df Compare January 21, 2026 22:02
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35.7% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants