feat: add support for last_day expression#3143
Merged
andygrove merged 2 commits intoapache:mainfrom Jan 21, 2026
Merged
Conversation
741139c to
67b3cf7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
============================================
+ Coverage 56.12% 60.04% +3.92%
- Complexity 976 1429 +453
============================================
Files 119 170 +51
Lines 11743 15774 +4031
Branches 2251 2606 +355
============================================
+ Hits 6591 9472 +2881
- Misses 4012 4981 +969
- Partials 1140 1321 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds native Comet support for Spark's last_day function, which returns the last day of the month for a given date. Uses the SparkLastDay implementation from datafusion-spark crate. Closes apache#3090 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
67b3cf7 to
73c9156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_dayfunctionSparkLastDayimplementation from thedatafusion-sparkcrateTest Plan
Closes #3090